Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KCL: All keyword arguments should use camelCase #5481

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

KCL: All keyword arguments should use camelCase #5481

wants to merge 5 commits into from

Conversation

adamchalmers
Copy link
Collaborator

Closes #5355

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Feb 24, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel Vercel
Copy link

vercel bot commented Feb 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 25, 2025 2:16pm

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.74510% with 19 lines in your changes missing coverage. Please review.

Project coverage is 86.28%. Comparing base (842054d) to head (a929dbd).

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/execution/import.rs 66.66% 13 Missing ⚠️
src/wasm-lib/kcl/src/std/import.rs 25.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5481      +/-   ##
==========================================
+ Coverage   86.26%   86.28%   +0.01%     
==========================================
  Files          95       95              
  Lines       35900    35901       +1     
==========================================
+ Hits        30969    30976       +7     
+ Misses       4931     4925       -6
Flag Coverage Δ
wasm-lib 86.28% <62.74%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtran jtran jtran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: kcl library line() - docs and in-app syntax error message are out-of-sync with actual parameter naming
2 participants
@adamchalmers @jtran